Open
Conversation
klauer
reviewed
Feb 13, 2023
Contributor
klauer
left a comment
klauer
left a comment
There was a problem hiding this comment.
Thanks for following along and submitting the PR!
| @@ -0,0 +1,8 @@ | |||
| def test_federica(test): | |||
Contributor
There was a problem hiding this comment.
The parameter test in your function here will is something that pytest will complain about.
It's because "test" isn't defined elsewhere.
Take a look at the example PR that shows how to parametrize the input - it's rather neat:
https://github.com/pcdshub/pcds-ci-test-repo-python/pull/6/files#diff-822bb6cd496579f843d5d333f49b1a4b0b78b43311dfb19d73fa37a7d0a2da14R10-R17
It says "use these values for the input parameter value and expect this to be the result". You write the test once and use a bunch of input parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is an open pull request test
Description
I sent two commits with no sensel because I had problems with authentication.
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?